-
Notifications
You must be signed in to change notification settings - Fork 35
[Color system] Add color factory and build modern tokens #105
Conversation
3bb8617
to
9f6d37b
Compare
9a9d3e0
to
ae4bd0a
Compare
ae4bd0a
to
8f5b18f
Compare
Co-authored-by: Dan Rosenthal <dan.rosenthal@shopify.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Kyle Durand <kyle.durand@shopify.com> Co-authored-by: Sara Hill <sara.hill@shopify.com>
8f5b18f
to
88bf5e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RC package contents look good to me from looking at unpkg, though I haven't tried using it within polaris-react to confirm end-to-end
@@ -121,7 +120,7 @@ thead th:first-child { | |||
} | |||
|
|||
code { | |||
font-family: Monaco, Consolas, 'Lucida Console', monospace; | |||
font-family: Monaco, Consolas, "Lucida Console", monospace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the convention was single quotes – if so, can you check if there is a Sass or Prettier configuration issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BPScott updated the prettier config to not format these files, so not an issue.
Ben, what was your rationale there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was deliberately changed - The docs folder is no longer formatted with prettier (but I do use sass's expanded style to maintain most of the readable formatting :)
I split the build into "legacy", "modern" and "docs" steps, this makes it easy to do just the modern build in shipit (to generate the dist-modern
folder), and also change the docs build to something new (probably a proper gatsby app) in the near future. In order to retain the old behaviour I would have had to either:
- have two steps "build-legacy:format" (to format the dist folder with prettier) and "docs:format" (to format the css in the docs folder with prettier) to that run after each of the build-legacy and docs steps
- A single step that runs after both "build-legacy" and "docs" - which makes makes the of steps a bit more convoluted and less self-contained.
I figured seeing as this file is generated content, and is going away imminently it is easier to only create a build-legacy:format step that formats just the dist folder, and skip formatting the docs folder css with prettier, as sass already does a pretty solid job. Incidentally I've just realised by formatting this file after sass does its thing we risk breaking the css.map file that the sass build generates (as that maps locations in the not-prettiered css file, not the version that's been ran through prettier)
Co-Authored-By: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
Co-Authored-By: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
Merging
the next branch into master, which includes several changes after the v2.7.0 release, as well as the latestchanges incorporating the color factory into tokens, and using TypeScript in the build for modern tokens.Release candidate on UNPKG: https://unpkg.com/browse/@shopify/polaris-tokens@2.8.0-rc.0/dist-modern/
This will all be released as v2.8.0, since these changes are not breaking.