Add token for new design language searchBar color #146
Conversation
src/configs/base.ts
Outdated
| { | ||
| name: 'background', | ||
| description: | ||
| 'For use as a background color, in components such as TopBar SearchField.', |
There was a problem hiding this comment.
This may be too specific. We should probably avoid naming components
There was a problem hiding this comment.
onSurfaceBackground might be confusing as it is a surface on a surface?
There was a problem hiding this comment.
We discussed this briefly but I think it makes sense. The purpose was for the search bar to match the background color of the page but that didn't quite meet a11y standards. So background on surface, though it may sound a bit odd, I think makes perfect sense. Open to other suggestions though
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [2.12.5] - 2020-09-08 | |||
|
|
|||
| - Added background under onSurface ([#146](https://github.com/Shopify/polaris-tokens/pull/146)) | |||
There was a problem hiding this comment.
This should go under unreleased. We can cut a new release tomorrow or Thursday together if you want
src/configs/base.ts
Outdated
| @@ -208,6 +208,15 @@ export const config: Config = { | |||
| }, | |||
| ], | |||
| onSurface: [ | |||
| { | |||
| name: 'background', | |||
| description: 'For use as a background color on components', | |||
There was a problem hiding this comment.
| description: 'For use as a background color on components', | |
| description: 'For use as a background color, in components on surface elements such as SearchField', |
I'm going back on what I said after realizing we mention components elsewhere in the docs. I'd just be a little more specific and add that it's the background for components overlaid on surface colored elements. Sorry 😄
Added a new background color to be used for the new design language search bar (a new semantic name)