This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
[Color system] fix color factory brittleness #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en a legacy theme object
danrosenthal
added a commit
that referenced
this pull request
Feb 20, 2020
* Added surface disabled variant and updated other variant configs ([#101](#101)) * Added TypeScript build for modern tokens, and shifted directory structures to differentiate between legacy and modern tokens ([#97](#97)) * Updated variant names and descriptions ([#96](#96)) * Added decorative icon variants ([#94](#94)) * Built changes from previous release, and added textOnInteractive variant ([#93](#93)) * Fixed an issue where legacy themes caused the color factory to throw ([#92](#92)) * Update color variants for consistency with changes in Polaris React ([#91](#91)) * Marked the config as optional and the colors as partial ([dd3d8fc](https://github.com/Shopify/polaris-tokens/commit/ * Actually exporting the types would be helpful ([4998856](4998856)) * Added the Color Factory. Long live the Color Factory! ([#89](#89)) Co-authored-by: Dan Rosenthal <dan.rosenthal@shopify.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Kyle Durand <kyle.durand@shopify.com> Co-authored-by: Sara Hill <sara.hill@shopify.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.