#1197: Changed Views to be driven by ReactViewManager #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android we were using regular views and viewmanagers to drive our native views. To be able to take advantage of the React Native functionality on views the Skia Views should be backed by a React View Manager which will ensure some functionality that will work out of the box. This fixes #1197 and pointer events (use example in 1197 to test), and also allows for setting backgroundColor as style for a Canvas. All tests and examples have been tested and works.
chrfalch
changed the title
|
awesome 🙌🏻 |
wcandillon
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android we were using regular views and viewmanagers to drive our native views. To be able to take advantage of the React Native functionality on views the Skia Views should be backed by a React View Manager which will ensure some functionality that will work out of the box.
This fixes #1197 and pointer events (use example in 1197 to test), and also allows for setting backgroundColor as style for a Canvas.
All tests and examples have been tested and works.