fix(🐛): fix concurrency issue with surface events #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.3.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I am not sure if this will solve all crashes since we sometimes got crash outside of screen change, but I will try to test this version ASAP. Great work thanks! |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle react-native-screens, we always recreate the SurfaceTexture when a destroy event happens (because RN screens keep the parent view alive). We believe that there is currently a race condition where a surface event like onSurfaceSizeChange may happen when we have already manually destroyed the surface (via the onDropViewInstance event).
This PR:
@kmagiera does this rational make sense here?
@hannojg @Nodonisko, I think I will release this patch regardless, as it provides better handling for RN Screens, even if it doesn't completely fix the race condition. I'm looking forward to reading your thoughts on this.