Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of from-git for lerna deploys #1174

Merged
merged 5 commits into from
May 18, 2021
Merged

Enable use of from-git for lerna deploys #1174

merged 5 commits into from
May 18, 2021
+23 −2

Conversation

dahukish
Copy link
Contributor

Enable from-git deploys by using machine.environment.FROM_GIT in your shipit.yml.

@dahukish dahukish self-assigned this May 14, 2021
@gigr
Copy link
Contributor

gigr commented May 18, 2021

Can you update the docs as well:

https://github.com/Shopify/shipit-engine/blob/a0a826555691f0c83cf74667e6df09911ff339e4/docs/npm-lerna.md

atesgoral
atesgoral reviewed May 18, 2021
View reviewed changes
docs/npm-lerna.md Outdated Show resolved Hide resolved
atesgoral
atesgoral reviewed May 18, 2021
View reviewed changes
docs/npm-lerna.md Outdated Show resolved Hide resolved
atesgoral
atesgoral reviewed May 18, 2021
View reviewed changes
docs/npm-lerna.md Outdated Show resolved Hide resolved
dahukish and others added 3 commits May 18, 2021 11:49
@dahukish @atesgoral
Update docs/npm-lerna.md
e4ef7b6 
Co-authored-by: Ates Goral <ates.goral@shopify.com>
@dahukish @atesgoral
Update docs/npm-lerna.md
227ccbf 
Co-authored-by: Ates Goral <ates.goral@shopify.com>
@dahukish @atesgoral
Update docs/npm-lerna.md
d9035cd 
Co-authored-by: Ates Goral <ates.goral@shopify.com>
@dahukish dahukish requested a review from atesgoral May 18, 2021 15:53
@dahukish dahukish requested a review from gigr May 18, 2021 16:42
@ajshepley ajshepley merged commit 628e29a into master May 18, 2021
@ajshepley ajshepley deleted the from-git branch May 18, 2021 19:22
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems May 18, 2021 19:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BPScott BPScott BPScott approved these changes

@atesgoral atesgoral atesgoral approved these changes

@vsumner vsumner vsumner approved these changes

@GoodForOneFare GoodForOneFare GoodForOneFare approved these changes

@gigr gigr gigr approved these changes

@michenly michenly Awaiting requested review from michenly

@marutypes marutypes Awaiting requested review from marutypes

Assignees

@dahukish dahukish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dahukish @gigr @atesgoral @BPScott @vsumner @GoodForOneFare @marutypes @ajshepley