Schedule individual CreateOnGithubJobs for each CommitDeploymentStatus that needs to be created #1342
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that needs to be created
kartiki975
approved these changes
Apr 12, 2024
erik-shopify
approved these changes
Apr 12, 2024
| @@ -10,7 +10,7 @@ class CommitDeployment < Record | |||
|
|
|||
| def create_on_github! | |||
| create_deployment_on_github! | |||
| statuses.order(id: :asc).each(&:create_on_github!) | |||
| statuses.order(id: :asc).each { |status| CreateOnGithubJob.perform_later(status) } | |||
There was a problem hiding this comment.
I don't remember for sure, but I think the id: :asc was here because the last status is what is important, so creation order is just as important.
So if you queue a job for each, the order now is random, which I'm pretty sure is a bug.
There was a problem hiding this comment.
Ah, that makes sense, thanks for catching that. I'm going to close this for now since this seemed like an easy enhancement but would actually be more complex than I thought. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1341.
CreateOnGithubJobalso can run for a long time. This breaks it up so that when it's called on a CommitDeployment, we schedule individual jobs to create each of that deployment's statuses on GitHub instead of doing all of that within the initialCreateOnGithubJobthat was called on the CommitDeployment.