Revert "Make RefreshCheckRunsJob and RefreshStatusesJob enqueue one of themselves per commit" #1343
+6
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f themselves per commit"
ruionweb
approved these changes
Apr 17, 2024
kwboyd-shopify
deleted the
revert-1341-kwb/split-check-runs-and-statuses-jobs-into-multiple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1341
Enqueuing these jobs separately led to too many GitHub requests being made at once, leading to hitting secondary rate limits frequently. I'll return to this issue when I have more bandwidth to debug, unless someone else has an idea of a quick fix for that issue.
@erik-shopify has an incoming PR to handle retries when we do hit GitHub secondary rate limits as well.