Fix race-y bug in db.server.ts #860
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surma
requested review from
paulomarg and
byrichardpowell
and removed request for
a team
paulomarg
approved these changes
Oct 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Fix race-y bug in db.server.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old code, two database connections get created in dev mode, which I think is not intentional.
Specifically:
prismavariable gets initialized to a new connection (asglobal.prismais unset).global.primsais not set,global.prismagets initialized to yet another, fresh connection.global.prisma, means we have to DB connections being used in parallel.This PR moves the global check to after the dev mode check.