await deleting the sessions on uninstall webhook #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphipps
force-pushed
the
iphipps/invalidate-session-on-uninstall
branch
from
f652121
to
b19673d
Compare
iphipps
changed the title
lizkenyon
approved these changes
Oct 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
…install await deleting the sessions on uninstall webhook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The afterAuth hook runs once on install. If a developer uninstalls and reinstalls, the afterAuth hook does not run because there is still a valid session. We need to properly await the deleting of sessions.
WHAT is this pull request doing?
Test this PR
shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#iphipps\/invalidate-session-on-uninstallapp/shopify.server.tsto see when it runs.Compare the behavior to
mainnotice how afterAuth is run once.Checklist
README.mdfile and other related documentation, if applicableCHANGELOG.md