Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Update scopes config in toml file #868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Oct 16, 2024

WHY are these changes introduced?

  • Scopes should be nested under the access_scopes key
  • Newer versions of the CLI will update the shopify.app.toml file to correctly nest the scopes field. But older versions of the CLI do not have this functionality, causing the required scopes to not be requested during install.

WHAT is this pull request doing?

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#liz/update-scopes-shopify-app-toml

Checklist

  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@lizkenyon lizkenyon requested a review from a team as a code owner October 16, 2024 18:42
Scopes must be nested under [accesss_scopes] field
@lizkenyon lizkenyon force-pushed the liz/update-scopes-shopify-app-toml branch from 684b8ed to c2163eb Compare October 16, 2024 18:44
@lizkenyon lizkenyon changed the title Update scopes config in toml file WIP Update scopes config in toml file Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant