This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Allow non-lowercase values in font, font-family, Sass variables starting with polaris, Sass/CSS variables containing font
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`font-family` and `font` are an exception where developers must have the freedom to specify non-lowercase values. For example: `BlinkMacSystemFont`.
tmlayton
approved these changes
Apr 3, 2019
tmlayton
reviewed
Apr 3, 2019
tmlayton
approved these changes
Apr 3, 2019
Co-Authored-By: kaelig <kaelig@users.noreply.github.com>
kaelig
changed the title
polaris, Sass/CSS variables containing font
kaelig
changed the title
polaris, Sass/CSS variables containing fontpolaris, Sass/CSS variables containing font
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
font-familyandfontare an exception where developers must have the freedom to specify non-lowercase values. For example:BlinkMacSystemFont.In the case of design tokens files, some variables should also be allowed to contain non-lowercase names:
$polarisand other variables containingfont.