Update IdentityCache compiler to generate correct multi methods #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwise-aiden
changed the title
bitwise-aiden
force-pushed
the
ba-identity-cache-multi
branch
from
68069dc
to
60c24f2
Compare
vinistock
approved these changes
Jan 11, 2024
paracycle
approved these changes
Jan 11, 2024
Co-authored-by: Emily Samp <emily.samp@shopify.com>
bitwise-aiden
force-pushed
the
ba-identity-cache-multi
branch
from
60c24f2
to
fcfd251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #1754
Implementation
While researching this, I noticed that there were some missing methods for the default
cache_indexcase as well. So as @KaanOzkan suggested in the issue, removing thelengthcheck fixed both issues.Tests
I've added some new tests and fixed old ones to illustrate the cases we are now expecting.