Support array types in typed_store compiler
#1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Jun 14, 2024
amomchilov
force-pushed
the
Alex/typed_store-arrays
branch
from
3b5f87f
to
71c3348
Compare
ipvalverde
reviewed
Jun 17, 2024
| type = if field.array | ||
| # `null: false` applies to the array itself, not the elements, which are always nilable. | ||
| # https://github.com/byroot/activerecord-typedstore/blob/2f3fb98/spec/support/models.rb#L46C34-L46C45 | ||
| # https://github.com/byroot/activerecord-typedstore/blob/2f3fb98/spec/active_record/typed_store_spec.rb#L854-L857 |
ipvalverde
reviewed
Jun 17, 2024
amomchilov
force-pushed
the
Alex/typed_store-arrays
branch
from
71c3348
to
ffb51e0
Compare
|
@ipvalverde Nice catch. I lost it somehow, but was able to revive it back from my editor's local history. Can you have a look and review? Cheers |
amomchilov
force-pushed
the
Alex/typed_store-arrays
branch
from
ffb51e0
to
30c373e
Compare
|
I ran these changes on core (cherry-picked in isolation, on top of the https://github.com/Shopify/shopify/commit/36d05ee84d0084e452f644d2b07e01eb54795a8a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1910
Implementation
Decide to refactor the
#type_formethod to take the wholeActiveRecord::TypedStore::Fieldobject, instead of just itstype_sym, because I would have needed to also pass infield.array. This way it can just access what it needs.This has the nice benefit of moving the
if field.nullresponsibility out of thedecoratemethod.Tests
I added tests for both
array: true, null: trueandarray: true, null: false. I didn't assert the type of all the methods (since they're mostly the same), just the getter/setter (just like how other tests check them).