Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.1.0 release #764

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Prepare 1.1.0 release #764

merged 1 commit into from
Aug 31, 2020

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Aug 31, 2020

Warn Checklist

  • This changes the interface and requires a Major/Minor version change.
  • I have 🎩'd these changes by using the commands I changed by hand.
  • I have added a dependancy to the project.
  • I have considered any potential impact on node-themekit

Release steps:

  • Update ThemeKitVersion in src/release/release.go and commit.
  • Make the release tool go install ./cmd/tkrelease
  • run git tag <version> && git push origin --tags && git push
  • Update the changelog.txt with the date of the version release
  • Release using tool
    • build all distributions make all
    • release tkrelease -k="AWS_ACCESS_KEY" -s="AWS_SECRET_KEY" vX.X.X
      • If releasing a different version than in src/release/version.go you can use -f to force, sometimes this is necessary for specific issue tags like v0.0.0-issue432 when trying to debug a issue.
      • Using beta/alpha tags on the version number will stop themekit from automatically updating to that version. It would have to be typed in specifically like theme update --version=v1.0.4-rc1
  • On GitHub create a new release for the tag and take note of any relevant changes.
    • Include a brief summary of all the changes
    • Include links to the Pull Requests that introduced these changes
  • Update the documentation website Update docs for checksums #735
    • run make serve_docs
    • update any changes to the API
    • commit changes
  • Update themekitversion in docs config docs/_config.yml to update the download links,
    then run make md5s to generate the checksums for the new files. Add these to the docs/_config.yml
    file as well.
  • Update Chocolatey package in the choco folder
    • Update the version in choco/themekit.nuspec
    • Update the version and checksums in choco/tools/chocolateyinstall.ps1
    • Run choco pack in a window VM
    • Log into chocolatey.org (use the themekit@shopify.com credentials) and submit an update for approval
  • Update themekit.rb formula for homebrew on https://github.com/Shopify/homebrew-shopify Update Theme Kit to v1.1.0 homebrew-shopify#182
    • run make gen_sha to generate the SHA256 for the darwin build
    • update the link and sha in the homebrew formula
  • Notify the maintainer of the AUR themekit package https://aur.archlinux.org/packages/shopify-themekit-bin
    of an update so they can release a new version.

changelog.txt Outdated
@@ -1,3 +1,7 @@
v1.1.0 (Aug 20, 2020)
=====================
- Release (no changes since beta2)

This comment was marked as resolved.

This comment was marked as resolved.

@andyw8 andyw8 force-pushed the andyw8/prepare-1.1.0-release branch from 4ad8b86 to 1ec2bbd Compare August 31, 2020 15:50
@@ -7,15 +7,15 @@ url: "https://shopify.github.io"
sass:
cache: true
# remember to update the checksums
themekitversion: "v1.0.2"
themekitversion: "v1.1.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanema Should this have been v1.0.3 already? The 'manual downloads' section on the site is still pointing to v1.0.2: https://shopify.github.io/themekit/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it should have been but it is clear that I never got around to it.

@andyw8 andyw8 force-pushed the andyw8/prepare-1.1.0-release branch from 1ec2bbd to 87965a3 Compare August 31, 2020 18:22
@andyw8 andyw8 force-pushed the andyw8/prepare-1.1.0-release branch from 87965a3 to 10802b6 Compare August 31, 2020 18:25
@andyw8 andyw8 merged commit 40429ef into master Aug 31, 2020
@tanema tanema deleted the andyw8/prepare-1.1.0-release branch August 31, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants