Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: metrics query range v3 #2265

Merged
merged 49 commits into from
Mar 23, 2023
Merged

feat: metrics query range v3 #2265

merged 49 commits into from
Mar 23, 2023

Conversation

srikanthccv
Copy link
Member

Fixes #2241

@github-actions github-actions bot added the enhancement New feature or request label Feb 15, 2023
Base automatically changed from issue-2240 to develop March 10, 2023 05:52
@srikanthccv srikanthccv marked this pull request as ready for review March 14, 2023 02:05
@srikanthccv
Copy link
Member Author

I am happy to split this further if you think it will help to you to review

@makeavish
Copy link
Member

I am happy to split this further if you think it will help to you to review

I am waiting to integrate #2453 changes in this PR

nityanandagohain
nityanandagohain previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't gone through metrics/v3/query_builder.go, but the common implementation part looks good to me.

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
13.6% 13.6% Duplication

@srikanthccv srikanthccv merged commit 17a5bc8 into develop Mar 23, 2023
@srikanthccv srikanthccv deleted the issue-2241 branch March 23, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makeavish makeavish makeavish approved these changes

@nityanandagohain nityanandagohain nityanandagohain left review comments

Assignees
No one assigned
Labels
codeball:needs-careful-review Codeball enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(metrics): query range v3
3 participants
@srikanthccv @makeavish @nityanandagohain