feat(logs): add tag attribute autocomplete for logs

[nityanandagohain]

Fixes #2248

[nityanandagohain]

I have added TagType in FilterAttributeKeyRequest and FilterAttributeValueRequest @srikanthccv @makeavish

Also in FilterAttributeValueRequest we will need the type of FilterAttributeKey so that we can query the correct column. I am suggestion to add FilterAttributeKeyDataType thoughts ?

[makeavish]

@nityanandagohain Why do we need tagType in request?

Also FilterAttributeKeyDataType can be added as it will be useful for cases where a tagKey is same but data type is different.

[nityanandagohain]

in autocomplete for keys, I think we can ignore TagType as we can return both attribute and resource keys

In autocomplete for values, we need to know the tagType, DataType of the key.

[makeavish]

In that case, we need tagType.
cc: @srikanthccv

[srikanthccv]

I have added TagType

The TagType will contain if it is a column, tag, or resource? This is fine.

Also in FilterAttributeValueRequest we will need the type of FilterAttributeKey so that we can query the correct column.

It is there https://github.com/SigNoz/signoz/pull/2244/files#diff-d3c63967220d7c8ed701bb4ec8f3ec8fe5a24a5264477429dfc209ca5a269374R76

Also fine with the DataType.

It would be easy to review and follow this here #2244 as you can make suggestions directly there.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
19 Code Smells

No Coverage information
23.3% Duplication

[makeavish]

@nityanandagohain I see that you are not creating a separate function for fetching aggregates attributes, I think there can be a future use case to return filtered attributes based on aggregate operator

[nityanandagohain]

@srikanthccv so you are asking if a key is missing in how tag_attributes table then how should it be handled in our query range v3 API right?

Or you are asking about value suggestion? as value suggestion won't be possible if key is not present.

[nityanandagohain]

@makeavish @srikanthccv the aggreateAttribute function is added now.

[srikanthccv]

Just one question, LGTM.

[srikanthccv]

Leaving it yourself to merge just in case if you want to test it more or make any minor changes.

[srikanthccv]

@nityanandagohain I only see the top-level fields in the staging app. Are there no other attributes? Can you make it so that there will be some attributes of different types for testing and developing for frontend folks?

[nityanandagohain]

@srikanthccv we have to deploy the signoz_otel_collector, have we done that ?

[srikanthccv]

Yes, that must have happened since your collector PR merged first, so images would have been pushed. @prashant-shahi earlier said to take care of that and it will work.

[prashant-shahi]

@srikanthccv And open API for health and version of the signoz-otel-collector (perhaps via query-service) would have been very helpful.
That way, we can display the otel version in SigNoz UI as well.