Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor issues found in development and enhancements #2542

Merged
merged 4 commits into from
Apr 7, 2023
Merged

fix: minor issues found in development and enhancements #2542

merged 4 commits into from
Apr 7, 2023

Conversation

srikanthccv
Copy link
Member

  • 0.5 -> 0.05
  • explicitly mention when a key is a column
  • add the filter operator symbols suggested by frontend
  • add the label for hist_quantile if the user didn't provide it already.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv marked this pull request as ready for review April 6, 2023 12:14
@nityanandagohain
Copy link
Member

nityanandagohain commented Apr 6, 2023 •
edited
Loading

Also please remove step from QueryRangeParamsV3 since it is not required and you have added step to builder queries.

@srikanthccv
Copy link
Member Author

srikanthccv commented Apr 6, 2023 •
edited
Loading

Metrics need the top-level step interval. To make it more explicit, the step interval at the top will be used in other query types.

@nityanandagohain
Copy link
Member

the step interval at the top will be used in other query types.

Got it thanks

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain merged commit 4db109c into develop Apr 7, 2023
@nityanandagohain nityanandagohain deleted the minor-fixes branch April 7, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

@makeavish makeavish Awaiting requested review from makeavish

Assignees
No one assigned
Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikanthccv @nityanandagohain