fix: several issues #5001
Merged
fix: several issues #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'd be happy to create one PR for each, but I thought some changes were tiny to get separate PR.
Fixes https://github.com/SigNoz/engineering-pod/issues/1278 - https://github.com/SigNoz/signoz/pull/5001/files#diff-a8c15149b48aee5261176aa62fa630bb7bde1c4362583ff95871ba24cec75bf9
Fixes https://github.com/SigNoz/engineering-pod/issues/1276 - https://github.com/SigNoz/signoz/pull/5001/files#diff-24e26b767b4b2d996d367bb6b35a4c73dbed69dae39bdb6bc1804a898a2158c5R1095-R1100
Part of #4978 - https://github.com/SigNoz/signoz/pull/5001/files#diff-9d8725f379f4d944c8461390f48daee34eb0622685f3bba9dd50f1370f55b2d0
Part of https://github.com/SigNoz/engineering-pod/issues/1269 - https://github.com/SigNoz/signoz/pull/5001/files#diff-5d93d2488907ea7ecfb28b45545142baa71a66a2999cf4420e9385a52ff8ddc4
Fixes https://github.com/SigNoz/engineering-pod/issues/1267 - https://github.com/SigNoz/signoz/pull/5001/files#diff-d3c63967220d7c8ed701bb4ec8f3ec8fe5a24a5264477429dfc209ca5a269374
Fixes https://github.com/SigNoz/engineering-pod/issues/1279 - https://github.com/SigNoz/signoz/pull/5001/files#diff-24e26b767b4b2d996d367bb6b35a4c73dbed69dae39bdb6bc1804a898a2158c5R1132-R1154