Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: import export dashboard #980

Merged
merged 16 commits into from
Apr 25, 2022
Merged

Feat: import export dashboard #980

merged 16 commits into from
Apr 25, 2022

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Apr 10, 2022 •
edited
Loading

Close #730

@palashgdev palashgdev self-assigned this Apr 10, 2022
@request-info
Copy link

request-info bot commented Apr 10, 2022

We would appreciate it if you could provide us with more info about this issue/pr!

@palashgdev palashgdev marked this pull request as draft April 10, 2022 19:00
@palashgdev palashgdev marked this pull request as ready for review April 18, 2022 17:27
@palashgdev palashgdev changed the title WIP: import export dashboard is in WIP Feat: import export dashboard Apr 18, 2022
@pranay01
Copy link
Collaborator

seeing errors in importing dashboard. Is there a different backend env I should use @palash-signoz
https://www.loom.com/share/5d2c062ce4f74bc784ee72884ff02a93

@pranshuchittora
Copy link
Contributor

@palash-signoz can you record a demo video so that this feature development gets documented and will also help in reviewing this PR

@palashgdev
Copy link
Contributor Author

@palash-signoz can you record a demo video so that this feature development gets documented and will also help in reviewing this PR

Sure

@ankitnayan
Copy link
Collaborator

@palash-signoz the new dashboard (json data) should be compatible with past versions, right? Otherwise existing customers will not see the dashboards after upgrade

@pranay01
Copy link
Collaborator

Seems working fine now. LGTM

pranay01
pranay01 previously approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@pranay01 pranay01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a functionality perspective. One improvement could be increasing size of the pop up window while importing to 1.3-1.4 times current size

prashant-shahi
prashant-shahi previously approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM

pranshuchittora
pranshuchittora suggested changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@pranshuchittora pranshuchittora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good.
Can you pls resolve the merge conflicts

@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

pranshuchittora
pranshuchittora approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good. I am not completely sure about the product requirements so won’t be able to take the final call to merge this, hence it would be great to get the go-ahead from the product team.

@ankitnayan ankitnayan merged commit b335d44 into SigNoz:develop Apr 25, 2022
@stnert stnert mentioned this pull request Mar 2, 2023
Merged
@stnert stnert mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranshuchittora pranshuchittora pranshuchittora approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

@ankit01-oss ankit01-oss Awaiting requested review from ankit01-oss

@pranay01 pranay01 Awaiting requested review from pranay01

@prashant-shahi prashant-shahi Awaiting requested review from prashant-shahi

Assignees

@pranshuchittora pranshuchittora

Labels
request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support import/export for dashboards
6 participants
@palashgdev @pranay01 @pranshuchittora @ankitnayan @prashant-shahi @ankit01-oss