Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra,prod): Add prod values builder and ws #8262

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

aarushik93
Copy link
Contributor

Background

We have our prod environment now, adding the prod values for builder and ws.
Doing some small clean ups and removing unused values, adding updated values such as to support www.

Changes 🏗️

  • Added prod values for builder and ws.
  • Updated Cors values
  • Updated managed cert / ingress to handle www

Has been deployed and fully tested in prod in the past week.

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested a review from a team as a code owner October 4, 2024 10:16
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/l labels Oct 4, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The file 'autogpt_platform/infra/helm/autogpt-builder/values.prod.yaml' contains placeholders for sensitive information such as GOOGLE_CLIENT_ID, GOOGLE_CLIENT_SECRET, and SENTRY_AUTH_TOKEN. Ensure that these values are not committed to version control and are securely managed using appropriate secret management practices.

⚡ Recommended focus areas for review

Configuration Change
The managed certificate now includes both the main domain and www subdomain. Ensure this change is intentional and aligns with the desired SSL/TLS setup.

Environment Variables
Several new environment variables have been added, and some existing ones have been removed or modified. Verify that these changes are correct and won't break existing functionality.

CORS Configuration
The CORS configuration is hardcoded to allow a specific origin. This might cause issues if the allowed origin needs to change or if multiple origins need to be supported.

Resource Allocation
The resource limits and requests for the production environment seem low. Consider if these are sufficient for production workloads.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 2e34722
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66ffc06daec24c00087f432d

@aarushik93 aarushik93 merged commit f811a6f into master Oct 4, 2024
12 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/tweak-builder-ws branch October 4, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant