-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Controlling #49
Comments
You imply that it is incompatible. But did you try it? If so can you please send the game's |
if you hold control (or and of those keys) it just selects it |
Okay good to know. But the version of Amecs and the version of Controlling you are using would help |
Okay. I found the problem and I know how to fix it. But it will take a while, because I am currently busy with other duty |
If you need to set the modifiers for a key until i fixed the mod: You can edit the |
Note that I have mentioned a workaround in that bug report over there. |
Yea, your workaround works. But the problem is not the mod load order. And I think it is not good when Controlling also tries to add key modifiers. This will cause more problems. I need to fix it in Amecs. And as I mentioned I will fix it. |
It would not cause more problems because there would be no need to use both mods simultaneously. |
A new version of Amecs is out. It now supports Controlling |
cant wait for this made into real amecs |
you gonna bump version of your fork cause this "made into real amecs" its takes long |
@Klotzi111 Hi after I used your amecs v1.4.3 the game crashes on startup ---- Minecraft Crash Report ---- Time: 5/11/22 java.lang.RuntimeException: Mixin transformation of net.minecraft.class_312 failed A detailed walkthrough of the error, its code path and all known details is as follows:-- Head -- |
@EGOIST1372 Please send me your |
@Klotzi111 here you go |
[19:45:11] [Render thread/ERROR]: Critical injection failure: LVT in net/minecraft/class_312::method_1598(JDD)V has incompatible changes at opcode 162 in callback amecsapi.mixins.json:MixinMouse->@Inject::isSpectator_onMouseScroll(JDDLorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;DF)V from mod amecsapi. This is everyghing about amecs in this log. btw its the same lines from crashlog. As far as i can tell... You trying play 1.18.2 and @Klotzi111 version don't support 1.18.2 |
Yea that is correct. This version of my amecs does not support mc 1.18.2. I remember me already fixing that 1.18.2 incompatibility. I try to release a 1.18.2 compatible version soon. |
can't wait - |
I released a new version 1.4.4 that works with mc 1.18.2. |
why your version cant go to official into amecs or seperate mod |
@Klotzi111 Thanks for update |
The original mod author knows about my fork. And some (old) pull requests of me are still pending. I could remind him about my fork by opening a new pull request. But in the end it is up to Siphalor (the author) to look into my fork and take over the changes. So maybe you ask him.
I definitely could but I do not feel that well about "stealing" the original source by releasing it as a new mod. I would prefer my changes to be in the original. |
(That is definitely not the right issue for that but it is too late now :D ) |
@Klotzi111 let me ask to be sure, your fork only solved controlling support or it has other changes and improvements as well? |
@EGOIST1372 My fork has additional features and many bug fixes:
I am currently working on 1.19 support for my forks. I think I will finish them the next days. |
@Klotzi111 can't you just make a pr for each fix and feature so all can get into the official build? |
Tearing apart the repo for every feature/fix is quite laborious and also not really good. Because I overhauled the internal api. So I would need to include the changes for that internal api in every fix which then would make merging more than one pr more difficult.
I do not know. Probably because I made so many changes. |
@EGOIST1372 I just wanted to inform you. My forks are now updated and released. |
@Klotzi111 thanks so much <3 |
@Klotzi111 |
@TalEdd My Amecs fork crashes because it is incompatible with the mod |
@Klotzi111 If you don't mind, could you put a list of incompatible mods on your forked github Readme page? |
@TalEdd Just another option I should have listed in the last post: You can replace
I do not know whether that mod is compatible or not. Just try it. (And optionally create an issue if it is not)
Yea. I good idea. I just did that |
controlling still breaks amecs for 1.19.2 for some reason. |
but you downloads klotzi's fork or siphalor's version? |
Siphalor's |
@netcore10 Currently Siphalor's is not compatible with Controlling. You can use my forked version. It is compatible. |
@Klotzi111 Your version crashes on 1.19.2, should i add an issue? |
@netcore10 Sure on my fork repo. I can only fix it if I know about it. 😄 |
@Klotzi111 Can't you just make a pr for each fix and feature so all can get
into the official build?
And why dev not implemented them?
…On Fri, Jul 1, 2022, 15:07 Klotzi111 ***@***.***> wrote:
@EGOIST1372 <https://github.com/EGOIST1372> My fork has additional
features and many bug fixes.
Many fixes in the controls GUI where you add and remove alternative
Keybindings.
Fixed a bug where the keybinding sometimes was not triggered with
alternative keys.
Made it more intuitive to remove alternative keys: Assigning "no key" will
remove the alternative.
Improved the internal API a lot. Especially in NMUKKeyBindingHelper.
I am currently working on 1.19 support for my forks. I think I will finish
them the next days.
—
Reply to this email directly, view it on GitHub
<#49 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUULT66KSFLKCZS6BELEYFLVR3C6TANCNFSM5LOVBYXA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Klotzi111 I installed your AMEC and NUMK and AMEC-api and it seems it crashes in 1.19.3 crash log: |
@Siphalor Hi |
Hi everyone, I'm just gonna explain the status of this issue and Klotzi's PR: When Klotzi opened his PR, we had a talk about the changes. I took a few attempts of separating the changes made in the PR but ultimately failed. I currently don't have a lot of time and energy for modding and have a lot of projects, so I can't give an ETA for any issues or suggestions. Since this thread is getting bumped regularly without any new information on the actual issue, I'm gonna lock this issue now. |
Add support for the Controlling
The text was updated successfully, but these errors were encountered: