Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebP animation speed bug #2624

Merged

Conversation

marklagendijk
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Milliseconds is the milli seconds component of the TimeSpan, TotalMilliseconds is the entire TimeSpan expressed as milliseconds.

Example, Timespan of 3.5 seconds:

  • Milliseconds: 500
  • TotalMilliseconds: 3500

Fixes #2619

`Milliseconds` is the milli seconds component of the TimeSpan, `TotalMilliseconds` is the entire TimeSpan expressed as milliseconds.

Example, Timespan of 3.5 seconds:
* `Milliseconds`: 500
* `TotalMilliseconds`: 3500
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤 Thanks!

@JimBobSquarePants JimBobSquarePants merged commit efd0c8e into SixLabors:main Jan 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GIF to WebP conversion issue: animation speed
3 participants