Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 signer generates incorrect url for region us-east-1 #191

Open
louischan-oursky opened this issue Mar 21, 2018 · 0 comments
Open

S3 signer generates incorrect url for region us-east-1 #191

louischan-oursky opened this issue Mar 21, 2018 · 0 comments
Assignees

Comments

@louischan-oursky
Copy link
Contributor

Expected Results

The generated URL should always be valid.

https://s3.amazonaws.com/<bucket>/<object-name>

Actual Results

https://s3-us-east-1.amazonaws.com/<bucket>/<object-name>

Steps to reproduce

  1. Use a S3 bucket located in region us-east-1
  2. ASSET_STORE_PUBLIC=YES
  3. skygear.asset.get_signer().sign(some_asset_id)

Cause

When ASSET_STORE_PUBLIC=YES, we naively concat the region to build the URL. The valid format is documented here

Workaround

Use ASSET_STORE_S3_URL_PREFIX=https://s3.amazonaws.com/<bucket>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants