Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #561: Set a default true return value for when source_files is empty. #563

Merged

Conversation

jarrodlombardo-EventBase
Copy link
Contributor

coverage_info.include_files? needs a default true return value for when source_files is empty.

@jarrodlombardo-EventBase
Copy link
Contributor Author

@dnedrow @ksuther This fixes #561 afaict.

@ksuther
Copy link
Contributor

ksuther commented Jun 20, 2024

I'm happy to make a release if someone can confirm it works for them.

@jarrodlombardo-EventBase
Copy link
Contributor Author

@gaige can you try this?

@gaige
Copy link

gaige commented Jun 20, 2024

I’ll look at it in a couple of hours. I don’t have access to my systems until I get home.

@gaige
Copy link

gaige commented Jun 20, 2024

@gaige can you try this?

@jarrodlombardo-EventBase
Managed to do it on my phone :-)

Looks good. All 8 runs I tried appear to have consistent output with prior version!

@ksuther
Copy link
Contributor

ksuther commented Jun 21, 2024

Thanks for the fix and thanks for checking! I'll make a new release soon.

@ksuther ksuther merged commit bdf0a82 into SlatherOrg:master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants