Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEP UI updates #49

Merged
merged 4 commits into from
Feb 9, 2024
Merged

AEP UI updates #49

merged 4 commits into from
Feb 9, 2024

Conversation

VijayanJayalakshmi
Copy link
Collaborator

No description provided.

aymanizz
aymanizz previously approved these changes Feb 8, 2024
Copy link
Member

@aymanizz aymanizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing in terms of the code itself but a few things before merging:

  • For the "Edit dataset's metadata & sharing options" button, can we make it title case just to match the letter case on the other surrounding buttons.

  • Because you're overriding a template and not using the ckan_extends the settings for plugins list needs to be updated so that the smdh plugin is second to the last plugin in the list (with a comment explaining why the plugin needs to be at the end of the list).
    This is because template extension is co-operative and relies on each plugin having the tag ckan_extends. Not that it would affect anything right now but future proofing so that if a plugin needs to extend this template there won't be any confusion.
    This setting is specified in multiple locations using env files in the ckan-smdh (under contrib/docker-ckan), and ckan-smdh-prod repo.

@VijayanJayalakshmi
Copy link
Collaborator Author

Sure, will do this update.

@VijayanJayalakshmi VijayanJayalakshmi merged commit 6bc0bbd into main Feb 9, 2024
1 check passed
@VijayanJayalakshmi VijayanJayalakshmi deleted the ui_tweaks branch February 9, 2024 10:42
@VijayanJayalakshmi VijayanJayalakshmi changed the title Updated the 'Data and Resources' title on the asset's page to 'Dataset's Files and Resources'. AEP UI updates Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants