Fix FileStream write caching #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid flushing SPIFFS write cache
|
@mikee47 Is this PR tested and ready to merge? |
|
@slaff Yes, I've tested this fix and happy with it for now, but generally I think we need to take another look at streams to ensure they all behave consistently, probably document behaviour a little better. Some of the streams are 'forward-only' (e.g. StreamTransformer-based ones) whilst others support proper seeking ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add position check in
FileStream::writebefore callingfileSeekto avoid flushing SPIFFS write cache.Fixes #1679