Added __FlashStringHelper support for PROGMEM

[brunnels]

Added in methods and macros to assist with PROGMEM usage

[anakod]

ICACHE_FLASH_ATTR isn't needed, because Sming building system locate all code to IROM by default. Instead you should mark with iram attrinbute to methods what should go to IRAM memory.

__FlashStringHelper will be very fine freature, I think.

[brunnels]

Okay, thanks for the info. I didn't know that. I'll modify this evening.
On Jul 22, 2015 9:24 AM, "Skurydin Alexey" notifications@github.com wrote:

ICACHE_FLASH_ATTR isn't needed, because Sming building system locate all
code to IROM by default. Instead you should mark with iram attrinbute to
methods what should go to IRAM memory.

__FlashStringHelper will be very fine freature, I think.

—
Reply to this email directly or view it on GitHub
#182 (comment).

[brunnels]

Okay, should be good to go now.

[anakod]

Why not NULL or nullptr for invalid values?

[brunnels]

NULL is macro'd to 0 which is int so throws a build error. You can try
nullptr and see if it builds but I think I tried it.
On Jul 26, 2015 10:41 AM, "Skurydin Alexey" notifications@github.com
wrote:

In Sming/Services/ArduinoJson/src/JsonBuffer.cpp
#182 (comment):

@@ -14,7 +14,7 @@
using namespace ArduinoJson;
using namespace ArduinoJson::Internals;

-JsonStringStorage JsonStringStorage::_invalid(NULL);
+JsonStringStorage JsonStringStorage::_invalid("");

Why not NULL or nullptr for invalid values?

—
Reply to this email directly or view it on GitHub
https://github.com/anakod/Sming/pull/182/files#r35494126.

[AutomationD]

@brunnels thank you so much for your PR.
We are trying to implement git-flow (#230). Can you please re-submit your PR to a feature branch?
For example feature/progmem-flashstring-helper?
Also, please squash your commits to one - too many of them.

[hreintke]

@brunnels :
We are restructuring and cleaning Sming repository and PR's.
Can you please squash your commits as some are reverting others and complete PR is unclear.
I have seen updates to ArduinoJson source. Can you explicitly mention why you want that update as it would diverge form the used library.
PS There are plans to upgrade to a newer version of ArduinoJson.

[hreintke]

This issue has been inactive for a long period and is being closed. If the issue is still valid please open a new with complete description