BitSet enhancements #2131
Merged
BitSet enhancements #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make BitSet constexpr-compatible Allows construction of fixed values which may be used as pre-defined masks, e.g. FileOpenFlags. * Add `size` template parameter Primary use case is enumerated types which only use a subset of the Storage. For example, uint32_t can store 32 values but an enum may only have 15. Attempting to use ~ operator would produce an incorrect result without this information. Use this to provide `domain()` (set containing all values). * Add static asserts to check template parameters are compile time * Add methods to correspond with std::bitset Also tested and fixed for old compiler (linux) * Add page to framework docs * Add bitset module to HostTests for integration testing
mikee47
force-pushed
the
feature/BitSet-upgrade
branch
from
0ea7f82
to
09c7470
Compare
slaff
reviewed
Oct 29, 2020
Sming/Core/Data/BitSet.h
Outdated
| { | ||
| value &= ~rhs.value; | ||
| value_ &= ~rhs.value_; |
There was a problem hiding this comment.
@mikee47 Please, remove leading or ending underscores.
Cannot have operator templates for non-BitSet values as they get picked up for other types and cause real problems. Therefore need to add them explicitly if required. Is there a neater way to do this? Require `extern toString` declaration as function may not have been declared yet.
|
@mikee47 Ready? |
|
@slaff OK, following further checks against my IFS branch this is working fine now. All done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make BitSet constexpr-compatible
Allows construction of fixed values which may be used as pre-defined masks, e.g. FileOpenFlags.
Add
sizetemplate parameterPrimary use case is enumerated types which only use a subset of the Storage.
For example, uint32_t can store 32 values but an enum may only have 15.
Attempting to use ~ operator would produce an incorrect result without this information.
Use this to provide
domain()(set containing all values).Add static asserts to check template parameters are compile time
Add methods to correspond with std::bitset
Also tested and fixed for old compiler (linux)
Add page to framework docs
Add bitset module to HostTests for integration testing
Add
toStringsupport