Library support for flatbuffers #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
reviewed
Mar 9, 2021
Comment on lines
9
to
17
| -#if defined(ARDUINO) && !defined(ARDUINOSTL_M_H) | ||
| - #include <utility.h> | ||
| -#else | ||
| +//#if defined(ARDUINO) && !defined(ARDUINOSTL_M_H) | ||
| +// #include <utility.h> | ||
| +//#else | ||
| #include <utility> | ||
| -#endif | ||
| +//#endif |
There was a problem hiding this comment.
Remove instead of comment-out ?
Comment on lines
47
to
48
| builder.Finish(orc); // You could also call `FinishMonsterBuffer(builder, | ||
| // orc);`. |
There was a problem hiding this comment.
Don't need to split comment
|
|
||
| #include <flatbuffers/flatbuffers> | ||
|
|
||
| Or directly the header file generated from the `flatc` compiler. |
There was a problem hiding this comment.
...Or directly use the header...
| @@ -0,0 +1,2 @@ | |||
| COMPONENT_INCDIRS := src/include | |||
| COMPONENT_SUBMODULES := src | |||
mikee47
reviewed
Mar 9, 2021
| } | ||
|
|
||
|
|
||
| Furher reading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible with all architectures using modern compilers.