FWFS stores objectIDs as offsets #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
changed the title
mikee47
force-pushed
the
update/fwfs-object-ids
branch
from
51b3076
to
612bf98
Compare
slaff
pushed a commit
that referenced
this pull request
Sep 27, 2021
This PR simplifies FWFS further by storing object identifiers as image offsets. Advantages: - No cache required - Faster because we can jump directly to the referenced record - Debugging and introspection is much easier The references are stored as packed integers (1 - 4 bytes). Note: Existing images need to be rebuilt. This change should have been included in #2315 as the use of numeric object IDs was part of the abstraction for object stores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies FWFS further by storing object identifiers as image offsets. Advantages:
The references are stored as packed integers (1 - 4 bytes).
Note: Existing images need to be rebuilt. This change should have been included in #2315 as the use of numeric object IDs was part of the abstraction for object stores.