Fix Hosted operation for Windows #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. User-provided HOSTED_COM_PORT gets overridden
|
@slaff I've left this WIP in case you'd like to add//modify this PR? |
So far it looks good to me. Test it on your Windows and if it works for you then let's merge it. |
slaff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Hosted Component so it builds and runs for Windows and also Esp32 architecture.
I've done some basic testing with Hosted running on an ESP32-S2 target, which pretty much worked straight away (apart from
pulseInsignature). However, as I use WSL if using a serial interface the Host application must be run in a Windows build. That needed a few fixes.This also seems like a good time to get the Kconfig settings for this Component updated!
simpleRPCinto Components (Hosted is a Component so should not depend on a Library)pulseInsignature for Esp32