Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RP2040: Bypass cache when reading flash memory directly #2601

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jan 18, 2023

Using normal XIP window forces reads through cache which will affect code execution speed.

@what-the-diff
Copy link

what-the-diff bot commented Jan 18, 2023

  • The variable flashaddr is not used in the function.
  • XIP_NOCACHE_NOALLOC_BASE + fromaddr should be assigned to xip\ctrl\hw->stream\addr instead of flashadd, because it's a physical address and can't be directly accessed by CPU.

@slaff slaff added this to the 4.8.0 milestone Jan 18, 2023
@slaff slaff merged commit 1cf436e into SmingHub:develop Jan 18, 2023
@mikee47 mikee47 deleted the fix/rp2040-flash-read branch January 19, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants