Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #2603

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Fix build issues #2603

merged 2 commits into from
Jan 18, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jan 18, 2023

Fix potential build issue with LittleFS where HWCONFIG_OPTS settings don't exist for Host architecture.
For example, building the Basic_IFS sample, which uses LittleFS, with make SMING_SOC=esp8266 HWCONFIG_OPTS=alternate will result in ** ERROR! Option 'alternate' undefined attempting to build fscopy.

To force re-linking of COMPONENT_TARGETS the build system touches the files.
Currently this creates the file if it doesn't exist but that can hide problems so is not desirable.

mikee47 added 2 commits January 18, 2023 11:45
If project specifies architecture-specific HWCONFIG_OPTS then build will fail.
@what-the-diff
Copy link

what-the-diff bot commented Jan 18, 2023

  • The subproject commit for LittleFS was changed from f5fc23fbb3112460dbd595ddf03b7ec2d45c8cb0 to e46dfdb5f73a09c7550d3d11706f9af5c902914c
  • In the project.mk file, touch commands were replaced with -t option (touch -ct) in order to preserve timestamps of files that are being touched

@slaff slaff added this to the 4.8.0 milestone Jan 18, 2023
@mikee47 mikee47 changed the title Fix/build issues Fix build issues Jan 18, 2023
@slaff slaff merged commit d38209f into SmingHub:develop Jan 18, 2023
@mikee47 mikee47 deleted the fix/build-issues branch January 19, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants