Esp32 build fixes #2836
Merged
Esp32 build fixes #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
force-pushed
the
fix/esp32-build-size
branch
from
199bd6c
to
78f0b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #2819 the size mainly seems to relate to two things:
Bug fixes
Size fixes
Disable WPA3 by default
This is also enabled by default in IDF 4.4 but can always be re-enabled if required.
It adds quite a lot to the image size.
Don't pull in stdio code from newlib
Sming doesn't use newlib stdio streams
Others
scanlog.pyto include missing builds (HostTests)checksdka pre-requisite