Revert SmingLocale.h encoding #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmingHub#1549 Initial commit as ascii (probably Windows) e9 SmingHub#1715 replaced with UTF-8 'replacement character' ef bf bd. UTF-8 code is ce a9 Best to stick with original encoding, UTF8 is likely to cause problems with existing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The french and german strings defined in
SmingLocale.happear to have been corrupted.Taking the é in février as an example:
PR #1549 Initial commit as ascii (probably Windows)
e9PR #1715 changed to UTF-8 'replacement character' ef bf bd.
The UTF-8 code would be ce a9 but as that's two bytes it could break existing code.
Best to stick with original encoding.