Reduce compile time #586
Merged
Reduce compile time #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 75.34% // Head: 74.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
==========================================
- Coverage 75.34% 74.29% -1.05%
==========================================
Files 52 53 +1
Lines 7341 7564 +223
==========================================
+ Hits 5531 5620 +89
- Misses 1810 1944 +134
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
elinorbgr
requested changes
Dec 19, 2022
And turn futures-channel into a dev-dependency as it is only used by a doc test.
Together with it's syn dependency thiserror takes a non-trivial amount of time to compile. The manual implementations are cleaned up versions of what was previously derived using thiserror.
The only thing syn is used for is parsing string literals. The copied code is about 160 lines.
Previously the smallvec![] macro would check if the elements fit in the inline capacity and generate code to handle both cases. By lifting the check out into wayland-scanner, rustc has to typeck and borrowck less code. This saves about 300ms of building wayland-protocols with all client features.
This makes the code a bit easier and ensures at compile time that the child_spec is never overwritten
This reduces the amount of SmallVec::into_iter and SmallVec::drop calls.
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits are mostly independent, so if you think any of the commits is bad for maintainability, I can easily drop it. The commits I'm most confident about are: