Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wayland.xml to 1.21.92 #608

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

chrisduerr
Copy link
Contributor

I think the most noteworthy change here is probably the addition of preferred_scale, which I think makes some sense to integrate considering fractional scale is already supported and implementing preferred scale on top of that should be pretty simple for compositors.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.31 🎉

Comparison is base (a37af45) 74.01% compared to head (4533ba0) 74.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   74.01%   74.32%   +0.31%     
==========================================
  Files          53       53              
  Lines        7607     7621      +14     
==========================================
+ Hits         5630     5664      +34     
+ Misses       1977     1957      -20     
Flag Coverage Δ
main 59.03% <ø> (+0.06%) ⬆️
test-- 79.05% <ø> (+0.74%) ⬆️
test--server_system 61.97% <ø> (+0.12%) ⬆️
test-client_system- 69.69% <ø> (+0.29%) ⬆️
test-client_system-server_system 51.62% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elinorbgr
Copy link
Member

1.21.92 is a beta release, shouldn't we wait for the proper 1.22 release?

In any case, could you add changelog entries to wayland-client and wayland-server covering this update?

@chrisduerr
Copy link
Contributor Author

1.21.92 is a beta release, shouldn't we wait for the proper 1.22 release?

That's something I was pondering myself, I'm not sure about your policy on this.

To me it seems unlikely that there will be major changes to protocols after they've been officially released, but I'm not familiar with Wayland's track record here.

But since new additions don't introduce breaking changes to existing protocols, I think it should be fine to expose unstable additions like this. Wayland protocol extensions are already heavily used in unstable revisions and I think since most compositor/client developers directly using this are likely looking at the protocols themselves, they can make their own decisions about relying on unstable/beta versions.

@elinorbgr
Copy link
Member

Ok, so 1.22 has been released now, with no changes since 1.21.92. I'm good with merging this, maybe let's just adjust the changelogs accordingly?

@elinorbgr
Copy link
Member

Thanks

@elinorbgr elinorbgr merged commit 04096e2 into Smithay:master Apr 19, 2023
@chrisduerr chrisduerr deleted the bump_wayland branch April 19, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants