backend/sys: associate imported proxy with correct event queue #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinorbgr
requested changes
Jul 29, 2024
|
I can confirm that this patch fixes the leak. |
|
Any reason to hold off on this? Seems better than the status quo. Also wanted to link #747, so that gets closed when this is merged. |
fixes a regression introduced in e777e85 which moved all proxies to a separate event queue but left proxies imported with `Backend::manage_object` on the default queue.
cmeissl
force-pushed
the
fix/manage_object_event_queue
branch
from
66382f2
to
274f8e6
Compare
elinorbgr
approved these changes
Sep 3, 2024
|
Just for future reference: I won't be testing this in the future since I no longer use that in my browser. Or at last I soon won't be using it anymore. But it obviously still makes sense to fix. |
ids1024
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a regression introduced in e777e85 which moved all proxies to a separate event queue but left proxies imported with
Backend::manage_objecton the default queue.cc @chrisduerr