Use new bridge config #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
commented
Jun 14, 2023
| AssetFilter::ByMultiLocation( | ||
| MultiLocationFilter::default() | ||
| .add_starts_with(EthereumLocation::get()) | ||
| ) // TODO: Change to registry contract address. For now accept any ethereum address. |
There was a problem hiding this comment.
Is it safe for us to trust any multilocation that is from Ethereum as a reserve location? I think so because only contracts that have SUBMIT_ROLE permission will be able to enqueue messages. However, another contract with SUBMIT_ROLE privilege could send through a Mint message and this predicate would not guard against that.
alistair-singh
added a commit
that referenced
this pull request
Jun 15, 2023
This reverts commit f1fcc16.
alistair-singh
added a commit
that referenced
this pull request
Jun 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-512
Snowfork companion: Snowfork/snowbridge#860