Reward relayer on BH for S->E transfer #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrong
commented
Jul 23, 2024
Comment on lines
409
to
+413
| pub(crate) fn calculate_fee( | ||
| gas_used_at_most: u64, | ||
| params: PricingParameters<T::Balance>, | ||
| _gas_used_at_most: u64, | ||
| _params: PricingParameters<T::Balance>, | ||
| ) -> Fee<T::Balance> { | ||
| // Remote fee in ether | ||
| let fee = Self::calculate_remote_fee( | ||
| gas_used_at_most, | ||
| params.fee_per_gas, | ||
| params.rewards.remote, | ||
| ); | ||
|
|
||
| // downcast to u128 | ||
| let fee: u128 = fee.try_into().defensive_unwrap_or(u128::MAX); | ||
|
|
||
| // multiply by multiplier and convert to local currency | ||
| let fee = FixedU128::from_inner(fee) | ||
| .saturating_mul(params.multiplier) | ||
| .checked_div(¶ms.exchange_rate) | ||
| .expect("exchange rate is not zero; qed") | ||
| .into_inner(); | ||
|
|
||
| // adjust fixed point to match local currency | ||
| let fee = Self::convert_from_ether_decimals(fee); | ||
|
|
||
| Fee::from((Self::calculate_local_fee(), fee)) | ||
| } | ||
|
|
||
| /// Calculate fee in remote currency for dispatching a message on Ethereum | ||
| pub(crate) fn calculate_remote_fee( | ||
| gas_used_at_most: u64, | ||
| fee_per_gas: U256, | ||
| reward: U256, | ||
| ) -> U256 { | ||
| fee_per_gas.saturating_mul(gas_used_at_most.into()).saturating_add(reward) | ||
| Fee::from((Self::calculate_local_fee(), T::Balance::zero())) |
There was a problem hiding this comment.
Will remove price params on chain and the remote portion of the fee.
yrong
commented
Jul 24, 2024
Comment on lines
+440
to
+441
| T::Token::mint_into(&Self::account_id(), fee_amount)?; | ||
| } |
There was a problem hiding this comment.
Mint the fee(in DOT) to pallet account of OutboundQueue.
yrong
commented
Jul 24, 2024
Comment on lines
+263
to
+266
| /// Fee locked by message hash | ||
| #[pallet::storage] | ||
| pub type LockedFee<T: Config> = StorageMap<_, Twox64Concat, H256, u128, ValueQuery>; | ||
|
|
There was a problem hiding this comment.
The storage map with Fee(in DOT) locked by MessageId.
yrong
commented
Jul 24, 2024
Comment on lines
+307
to
+315
| pub fn add_fees( | ||
| origin: OriginFor<T>, | ||
| message_id: H256, | ||
| fee_amount: BalanceOf<T>, | ||
| ) -> DispatchResult { | ||
| let who = ensure_signed(origin)?; | ||
| Self::lock_fee(message_id, fee_amount, Some(who))?; | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Essentially just a transfer from the sender origin to the pallet account.
yrong
changed the title
yrong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.