Use FromNetwork #80
Merged
Use FromNetwork #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
approved these changes
Dec 20, 2023
| } | ||
|
|
||
| #[test] | ||
| fn from_network_contains_works() { |
| Some(sp_std::vec![ | ||
| EthereumLocation::get().interior.split_global().expect("invalid configuration for Ethereum").1, | ||
| ]), | ||
| Some(sp_std::vec![Junctions::Here]), |
There was a problem hiding this comment.
Yeah, its basically the equivalent of
EthereumLocation::get().interior.split_global().expect("invalid configuration for Ethereum").1
Because EthereumLocation.get().interior is GlobalConsensus(Ethereum { chain_id: .. }), then we split_global() which strips the first global consensus part, leaving ( GlobalConsensus(Ethereum { chain_id: .. }) , Junctions::Here ). Then we take the second member of the tuple with .1.
alistair-singh
force-pushed
the
alistair/use-from-network
branch
from
f5f8155
to
dd71915
Compare
claravanstaden
pushed a commit
that referenced
this pull request
Dec 20, 2023
* wip * use from network * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowbridge: Snowfork/snowbridge#1075