Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local setup for Westend #1262

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Local setup for Westend #1262

merged 7 commits into from
Aug 5, 2024

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jul 23, 2024

@yrong yrong marked this pull request as ready for review July 24, 2024 04:21
@yrong
Copy link
Contributor Author

yrong commented Jul 24, 2024

Tested the E2E tests work as expected for westend local setup.

@claravanstaden Just let you know I revert #1251 which does not apply to our forked polkadot-sdk or submit extrinsic will fail. But we can upgrade polkadot-sdk to a more recent version and add that back in another PR.

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden
Copy link
Contributor

@yrong I have updated https://github.com/Snowfork/polkadot-sdk with the latest from upstream. Please let me know if it resolves the gsprc issue for you. :)

@yrong
Copy link
Contributor Author

yrong commented Jul 28, 2024

Hey Clara, thanks for the upgrade. Though it still requires Snowfork/polkadot-sdk@c8f9fe0 to include the gsprc fix.

Just tested the e2e tests work as expected.

Comment on lines -72 to -78
if (process.env.NODE_ENV == "production") {
currentAuthorities = await api.query.beefyMmrLeaf.beefyAuthorities<AuthoritySet>()
nextAuthorities = await api.query.beefyMmrLeaf.beefyNextAuthorities<AuthoritySet>()
} else {
currentAuthorities = await api.query.mmrLeaf.beefyAuthorities<AuthoritySet>()
nextAuthorities = await api.query.mmrLeaf.beefyNextAuthorities<AuthoritySet>()
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To bypass the deprecated rpc.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yrong yrong merged commit 96565f2 into main Aug 5, 2024
1 check passed
@yrong yrong deleted the ron/westend branch August 5, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants