Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a promise from transformStream shim #21

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Conversation

jhiesey
Copy link
Member

@jhiesey jhiesey commented Jun 11, 2021

This makes it possible to determine when a stream is done and whether it was successful, similar to the promise returned by native ReadableStream.pipeTo

@jhiesey jhiesey temporarily deployed to ci June 11, 2021 00:01 Inactive
@jhiesey jhiesey temporarily deployed to ci June 11, 2021 00:08 Inactive
@jhiesey jhiesey temporarily deployed to ci June 11, 2021 00:08 Inactive
@jhiesey jhiesey marked this pull request as ready for review June 11, 2021 01:42
@feross feross temporarily deployed to ci June 16, 2021 18:34 Inactive
Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM

lib/transform-stream.js Outdated Show resolved Hide resolved
lib/transform-stream.js Outdated Show resolved Hide resolved
lib/transform-stream.js Outdated Show resolved Hide resolved
@jhiesey jhiesey temporarily deployed to ci June 16, 2021 19:04 Inactive
@jhiesey jhiesey temporarily deployed to ci June 16, 2021 19:04 Inactive
@jhiesey jhiesey merged commit fa846d7 into master Jun 16, 2021
@jhiesey jhiesey deleted the transform-promise branch June 16, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants