Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to request join to any teams. #221

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

xenohim
Copy link
Contributor

@xenohim xenohim commented Nov 7, 2023

Add a new button Request Join to allow anyone to rejoin any teams by using the input of the Create button. Create button is hidden if the team exists and Request Join otherwise.

@finnbear
Copy link
Member

finnbear commented Nov 7, 2023

Thanks!

allow anyone to rejoin any teams

*any team that you can type on your keyboard which anecdotally, at the time of writing, is 50% of teams on the leaderboard. Emoji/foreign language teams remain difficult to join.

image

Still, this is an improvement over the status quo, so I'll accept the PR :)

@xenohim
Copy link
Contributor Author

xenohim commented Nov 7, 2023

*any team that you can type on your keyboard which anecdotally, at the time of writing, is 50% of teams on the leaderboard. Emoji/foreign language teams remain difficult to join.

Stop giving me ideas ! :)

@xenohim xenohim closed this Nov 7, 2023
@xenohim xenohim reopened this Nov 7, 2023
@finnbear
Copy link
Member

finnbear commented Nov 7, 2023

Let me know if you want to revise before merge :)

E.g. using the "convert to draft" feature

@finnbear finnbear merged commit 6a0d916 into SoftbearStudios:main Nov 7, 2023
2 checks passed
@finnbear finnbear added the client Only related to the client label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Only related to the client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants