Document limitation with comment in DTD #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilchik-elena
approved these changes
Dec 17, 2018
| @@ -192,9 +192,13 @@ private void finalizePreviousNode(XmlFilePosition endLocation) { | |||
| private XMLStreamReader getXmlStreamReader() throws XMLStreamException { | |||
| Reader reader = new StringReader(content); | |||
|
|
|||
| XMLInputFactory factory = XMLInputFactory.newInstance(); | |||
| // forcing the XMLInputFactory implementation class, in order to be sure that we are going to us the adequate | |||
| DocumentType documentType = (DocumentType) document.getFirstChild(); | ||
| assertRange(documentType, Location.NODE, 2, 0, 7, 2); | ||
| Node lastChild = document.getLastChild(); | ||
| // location of the node is wrong, should be line 8, event are not at the correct place |
| "<!ELEMENT menu (modulo)* >\n" + | ||
| "]>\n" + | ||
| "<menu value=\"foo\"></menu>").getDocument(); | ||
| assertThat(document.getChildNodes().getLength()).isEqualTo(2); |
There was a problem hiding this comment.
something is wrong with indentation
m-g-sonar
force-pushed
the
document_dtd_wrong_location
branch
from
27461e6
to
b337b84
Compare
m-g-sonar
force-pushed
the
document_dtd_wrong_location
branch
from
b337b84
to
c0adab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://jira.sonarsource.com/browse/SONARXML-73
Reported in Woodstox repository: FasterXML/woodstox#67