[PVR] CPVRGUIActionsPowerManagement: Reduce usage of 'const shared_pt…

…r<CFileItem>&' parameters. Use 'const CFileItem&' instead.
Spacetech · Oct 13, 2022 · ab667b5 · ab667b5
1 parent 41379b4
commit ab667b5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/xbmc/pvr/guilib/PVRGUIActionsPowerManagement.cpp b/xbmc/pvr/guilib/PVRGUIActionsPowerManagement.cpp
@@ -135,7 +135,7 @@ bool CPVRGUIActionsPowerManagement::AllLocalBackendsIdle(
       CServiceBroker::GetPVRManager().Timers()->GetActiveRecordings();
   for (const auto& timer : activeRecordings)
   {
-    if (EventOccursOnLocalBackend(std::make_shared<CFileItem>(timer)))
+    if (EventOccursOnLocalBackend(timer))
     {
       causingEvent = timer;
       return false;
@@ -154,7 +154,7 @@ bool CPVRGUIActionsPowerManagement::AllLocalBackendsIdle(
       return false;
     }
 
-    if (EventOccursOnLocalBackend(std::make_shared<CFileItem>(timer)))
+    if (EventOccursOnLocalBackend(timer))
     {
       causingEvent = timer;
       return false;
@@ -164,17 +164,15 @@ bool CPVRGUIActionsPowerManagement::AllLocalBackendsIdle(
 }
 
 bool CPVRGUIActionsPowerManagement::EventOccursOnLocalBackend(
-    const std::shared_ptr<CFileItem>& item) const
+    const std::shared_ptr<CPVRTimerInfoTag>& event) const
 {
-  if (item && item->HasPVRTimerInfoTag())
+  const std::shared_ptr<CPVRClient> client =
+      CServiceBroker::GetPVRManager().GetClient(CFileItem(event));
+  if (client)
   {
-    const std::shared_ptr<CPVRClient> client = CServiceBroker::GetPVRManager().GetClient(*item);
-    if (client)
-    {
-      const std::string hostname = client->GetBackendHostname();
-      if (!hostname.empty() && CServiceBroker::GetNetwork().IsLocalHost(hostname))
-        return true;
-    }
+    const std::string hostname = client->GetBackendHostname();
+    if (!hostname.empty() && CServiceBroker::GetNetwork().IsLocalHost(hostname))
+      return true;
   }
   return false;
 }

diff --git a/xbmc/pvr/guilib/PVRGUIActionsPowerManagement.h b/xbmc/pvr/guilib/PVRGUIActionsPowerManagement.h
@@ -40,7 +40,7 @@ class CPVRGUIActionsPowerManagement : public IPVRComponent
   CPVRGUIActionsPowerManagement const& operator=(CPVRGUIActionsPowerManagement const&) = delete;
 
   bool AllLocalBackendsIdle(std::shared_ptr<CPVRTimerInfoTag>& causingEvent) const;
-  bool EventOccursOnLocalBackend(const std::shared_ptr<CFileItem>& item) const;
+  bool EventOccursOnLocalBackend(const std::shared_ptr<CPVRTimerInfoTag>& event) const;
   bool IsNextEventWithinBackendIdleTime() const;
 
   CPVRSettings m_settings;