Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial content for the Chords library #1

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

dpikhulya
Copy link
Contributor

@dpikhulya dpikhulya commented Aug 27, 2024

This PR adds the current state of the Chords library along with a basic Gradle project.

It doesn't include the config Git module yet (it will follow separately).

This includes the current state of the Chords library along
with a basic Gradle project.
@dpikhulya dpikhulya self-assigned this Aug 27, 2024
@dpikhulya dpikhulya requested a review from armiol August 28, 2024 17:10
Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpikhulya LGTM with a comment to address.

Also, in the next pull request, let's set the library version, and mention in the README.md this is an experimental library at this stage..

#
# These are explicitly windows files and should use crlf
*.bat text eol=crlf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the one from ProtoData as an example.

@dpikhulya dpikhulya merged commit 9cc9862 into master Aug 28, 2024
2 checks passed
@dpikhulya dpikhulya deleted the initial-content branch August 28, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants