Implement the modal window functionality #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ositionProvider` in the `ModalWindow` file.
…plicationUI` class.
armiol
requested changes
Oct 7, 2024
| * The responsibility for handling the appearance, layout, and structure | ||
| * of the modal window is delegated to the provided composable content block. | ||
| * | ||
| * @param onCancel The callback triggered when the user clicks outside the modal window. |
There was a problem hiding this comment.
The idea of the modal window is that no matter where user clicks outside the window borders, it stays on top. Otherwise, it's not modal.
The only way to close the window is to act explicitly. E.g. press some "Close" button.
In terms of the domain-related processes, there should be a way to confirm such a closure with the user first. Otherwise, the outcome of presumably active process (supplied on the UI by this window) is unclear.
…AppWindow` class.
# Conflicts: # dependencies.md
…gContainer` component.
armiol
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
ModalWindowcomponent and extends the API of theAppWindowclass allowing the creation and management of modal dialogs within the application.