Perform Kotlin code analysis during the build #754
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #754 +/- ##
=========================================
Coverage 71.82% 71.82%
Complexity 1328 1328
=========================================
Files 201 201
Lines 4887 4887
Branches 361 361
=========================================
Hits 3510 3510
Misses 1245 1245
Partials 132 132 |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
@alexander-yevsyukov @armiol Please take a look. Detekt is set up here without |
base/build.gradle.kts
Outdated
|
|
||
| detekt { | ||
| buildUponDefaultConfig = true | ||
| baseline = file("config/quality/detekt-baseline.xml") |
There was a problem hiding this comment.
What happens if these files are not there?
I'm asking so that we can use script plugins (e.g. from build-logic).
There was a problem hiding this comment.
OK, let's now assume we have buildSrc (so that we don't introduce too many changes with build-logic).
Can we have these general things done there? Together with checking for the presence of configuration files, please.
| @@ -0,0 +1,9 @@ | |||
| naming: | |||
There was a problem hiding this comment.
This looks like settings that are applicable to all subprojects. So, they should probably go under ./config/quality. I mean be not under submodule, but under config of the project root.
yevhenii-nadtochii
force-pushed
the
detekt-as-gradle-task
branch
from
d321949
to
55571d9
Compare
[`buildSrc`] Perform Kotlin code analysis during the build
|
@armiol @alexander-yevsyukov PTAL. |
| @@ -26,7 +26,6 @@ | |||
|
|
|||
| package io.spine.internal.dependency | |||
|
|
|||
| // https://pmd.github.io/ | |||
There was a problem hiding this comment.
Please restore this. Newer config fixes this acceidental removal.
This PR moves Detekt code analyzing from GitHub workflow to Gradle
detekttask. This task is bound tocheckby default, thus it will be executed with./gradlew build.It addresses config #412.
In particular, this changeset does the following:
detekt-analysisGitHub workflow.configwith implementeddetekt-code-analysisscript-plugin.baseandtestlibmodules.Please note, due to a bug in Gradle, plugins are applied with string ID instead of referencing to dependency-objects.
Detekt reported two finding during the build:
catchblock. I've renamed it toignored.TruthExtensions.kt. I've suppressed this one with the baseline file.